fix(playwright): Validate browser context options before calling launch_persistent_context#1813
Closed
ReinerBRO wants to merge 1 commit intoapify:masterfrom
Closed
Conversation
vdusek
changed the title
vdusek
changed the title
Collaborator
|
Hello, we already have #1796 in progress, so I guess we should just finalize and merge that one. |
Collaborator
|
Hi @ReinerBRO, thanks for the PR, however we already have #1796 opened, so closing in favour of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the persistent Playwright browser path so unsupported browser_new_context_options are rejected early with a clear error instead of failing later inside launch_persistent_context(). Adds a regression test covering storage_state.